[webkit-reviews] review granted: [Bug 122000] [GStreamer] Support "chapter" text tracks : [Attachment 213014] Add ENABLE(VIDEO_TRACK) checks

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 122000: [GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000

Attachment 213014: Add ENABLE(VIDEO_TRACK) checks
https://bugs.webkit.org/attachment.cgi?id=213014&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213014&action=review


>
Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStrea
mer.h:36
> +class InbandMetadataTextTrackPrivateGStreamer : public
InbandTextTrackPrivate {

Nit: FINAL

> LayoutTests/media/in-band-cues.js:185
> +	   for (var i = 1; i < numInBandTracks + 1; ++i) {
> +	     compareTracks("video.textTracks[" + (i + 1) + "]", "inbandTrack" +
i);
> +	   }

Nit: braces aren't necessary here