[webkit-reviews] review granted: [Bug 124561] AX: Add AXUIElementCountForSearchPredicate parameterized attribute. : [Attachment 217514] Patch for review.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 124561: AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
https://bugs.webkit.org/show_bug.cgi?id=124561

Attachment 217514: Patch for review.
https://bugs.webkit.org/attachment.cgi?id=217514&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217514&action=review


> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:200
> +    NSMutableDictionary* parameterizedAttribute = [NSMutableDictionary
dictionary];

this * should be on the other side since it's an ObjC object

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:213
> +	       if (searchKeyString) {

braces not necessary since it's a single line

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1017
> +    NSDictionary* parameterizedAttribute =
searchPredicateParameterizedAttributeForSearchCriteria(context, startElement,
isDirectionNext, UINT_MAX, searchKey, searchText, visibleOnly);

* on wrong side

> Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:1029
> +    NSDictionary* parameterizedAttribute =
searchPredicateParameterizedAttributeForSearchCriteria(context, startElement,
isDirectionNext, 1, searchKey, searchText, visibleOnly);

* on wrong side

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:215
> +    NSMutableDictionary* parameterizedAttribute = [NSMutableDictionary
dictionary];

* on wrong side

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:228
> +	       if (searchKeyString) {

braces not necessary

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1046
> +    NSDictionary* parameterizedAttribute =
searchPredicateParameterizedAttributeForSearchCriteria(context, startElement,
isDirectionNext, UINT_MAX, searchKey, searchText, visibleOnly);

* on wrong side

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1058
> +    NSDictionary* parameterizedAttribute =
searchPredicateParameterizedAttributeForSearchCriteria(context, startElement,
isDirectionNext, 1, searchKey, searchText, visibleOnly);

* on wrong side