[webkit-reviews] review granted: [Bug 124975] Fix a crash in the webaudio source provider when the audio track is going away. : [Attachment 218078] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 30 14:07:04 PST 2013
Eric Carlson <eric.carlson at apple.com> has granted Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 124975: Fix a crash in the webaudio source provider when the audio track is
going away.
https://bugs.webkit.org/show_bug.cgi?id=124975
Attachment 218078: Patch
https://bugs.webkit.org/attachment.cgi?id=218078&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218078&action=review
>> Source/WebCore/ChangeLog:8
>> + Before this patch, it was hittinh a use-after-free crash when the
audio
>
> Typo: hittinh. Also, I'm not sure it's a common thing to do when merging
Blink changes but I think it'd be good to mention the blink commit and its
author in the ChangeLog.
Yes, we typically include the Blink commit url and author in the ChangeLog.
More information about the webkit-reviews
mailing list