[webkit-reviews] review granted: [Bug 125022] [Cocoa] Make WKBrowsingContextController work with WKObject wrapping : [Attachment 218081] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 125022: [Cocoa] Make WKBrowsingContextController work with WKObject
wrapping
https://bugs.webkit.org/show_bug.cgi?id=125022

Attachment 218081: Patch
https://bugs.webkit.org/attachment.cgi?id=218081&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218081&action=review


> Source/WebKit2/ChangeLog:25
> +	   Lazily setup the load and policy clients only once a delegate has
been set to allow

s/setup/set up/

> Source/WebKit2/ChangeLog:35
> +	   Add wrapper() helper and declare conformance to the WKObject
protocol. Remove no longer used
> +	   _initWithPageRef: and _browsingContextControllerForPageRef: helpers.


Exciting!

> Source/WebKit2/ChangeLog:47
> +	   Stop caching the WKBrowsingContextController, as it no long makes
sense since it is the same object
> +	   as the WebPageProxy.

Everything is falling into place!

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:614
> +- (void)_finishInitialization

Not part of the protocol so maybe reorder it out of this section.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:51
> +#import "WKBrowsingContextControllerInternal.h"

This should go before the < imports.