[webkit-reviews] review denied: [Bug 117523] [WK2] Proof of concept to inject custom JavaScript objects on WebWorker context. : [Attachment 218029] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Tullio Lucena
<tullio.lucena at openbossa.org>'s request for review:
Bug 117523: [WK2] Proof of concept to inject custom JavaScript objects on
WebWorker context.
https://bugs.webkit.org/show_bug.cgi?id=117523

Attachment 218029: Patch
https://bugs.webkit.org/attachment.cgi?id=218029&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
I am not completely sure of the utility of this, so please add use cases.

Some general concerns:
- Use of global callback functions is a bad design.  Please use a per-object
client interface.
- I am not clear on how this would work for SharedWorkers since the
InjectedBundle will probably not run in shared worker processes (at least as
currently designed).
- The use of a boolean to indicate Dedicated/Shared should be avoided. Please
use an enum to allow for more types of workers in the future.
- The callbacks need more contextual information.  For instance, in the
non-worker versions of these, we pass a WebFrame, which includes things like
the URL.
- This should be modeled on the DOMWindowExtension concept, so that it can deal
with being the page cache. 
- Perhaps Workers should have their own separate bundle they load. That would
allow for a clear threading model and work for Shared workers.