[webkit-reviews] review denied: [Bug 124965] [EFL] glViewport() is set up than the viewSize. : [Attachment 218028] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 28 19:57:21 PST 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied hunseopJeong
<hs85.jeong at samsung.com>'s request for review:
Bug 124965: [EFL] glViewport() is set up than the viewSize.
https://bugs.webkit.org/show_bug.cgi?id=124965

Attachment 218028: Patch
https://bugs.webkit.org/attachment.cgi?id=218028&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review


> Source/WebKit2/ChangeLog:3
> +	   [EFL] glViewport() is set up than the viewSize.

I really don't understand what does this title means now. Do you mean that
glViewport size is bigger than viewSize ? Anyway, it seems to me that you want
to change glViewport size with viewSize, right ?

> Source/WebKit2/ChangeLog:9
> +	   Nevertheless, the viewport is translated when being painted, it
looks correct.

AFAIK, we should fix something when it is *correct*, not *looks correct*.


More information about the webkit-reviews mailing list