[webkit-reviews] review canceled: [Bug 117523] [WK2] Proof of concept to inject custom JavaScript objects on WebWorker context. : [Attachment 218024] Patch

[bugzilla-daemon at webkit.org]

Tullio Lucena <tullio.lucena at openbossa.org> has canceled Tullio Lucena
<tullio.lucena at openbossa.org>'s request for review:
Bug 117523: [WK2] Proof of concept to inject custom JavaScript objects on
WebWorker context.
https://bugs.webkit.org/show_bug.cgi?id=117523

Attachment 218024: Patch
https://bugs.webkit.org/attachment.cgi?id=218024&action=review

------- Additional Comments from Tullio Lucena <tullio.lucena at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218024&action=review


Thanks for your comments and for have added others reviewers.
I will fix these mistakes now.

>> Tools/TestWebKitAPI/PlatformEfl.cmake:57
>> +	${TESTWEBKITAPI_DIR}/Tests/WebKit2/WebWorker_Bundle.cpp
> 
> Wrong alphabetical order.

When I run the webkit-check-style, the way it is, there's no alphabetical order
error.

In the other place I have these errors:

Tools/TestWebKitAPI/PlatformEfl.cmake:58:  Alphabetical sorting problem.
"${TESTWEBKITAPI_DIR}/Tests/WebKit2/WebWorker_Bundle.cpp" should be before
"${TESTWEBKITAPI_DIR}/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActi
ve_Bundle.cpp".  [list/order] [5]

Tools/TestWebKitAPI/PlatformEfl.cmake:59:  Alphabetical sorting problem.
"${TESTWEBKITAPI_DIR}/Tests/WebKit2/WebWorker_Bundle.cpp" should be before
"${TESTWEBKITAPI_DIR}/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.
cpp".  [list/order] [5]

>> Tools/TestWebKitAPI/PlatformEfl.cmake:100
>> +	WebWorker
> 
> Generally, lower case is placed below upper case.

Ok.

>> Tools/TestWebKitAPI/Tests/WebKit2/WebWorker_Bundle.cpp:35
>> +#include <cstdio>
> 
> Add a new line.

Ok.

> Tools/TestWebKitAPI/Tests/WebKit2/WebWorker_Bundle.cpp:36
> +using namespace std;

This using is useless, I will remove it too.

>> Tools/TestWebKitAPI/Tests/WebKit2/WebWorker_Bundle.cpp:76
>> +	WebWorkerTest(const std::string& identifier)
> 
> explicit ?

Ok.