[webkit-reviews] review granted: [Bug 124837] Set m_obj member variable as private : [Attachment 217926] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 124837: Set m_obj member variable as private
https://bugs.webkit.org/show_bug.cgi?id=124837

Attachment 217926: Patch
https://bugs.webkit.org/attachment.cgi?id=217926&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=217926&action=review


> Source/WebCore/ChangeLog:3
> +	   Set m_obj member variable as private

The title is not informative. Maybe something like "Rename
InlineIterator::m_obj and make it private"

> Source/WebCore/rendering/InlineIterator.h:69
> +    RenderObject* renderer() const { return m_renderer; }

It would be good to make this return a reference and ASSERT(m_renderer). Any
valid null checks in client would be replaced with atEnd() tests. For future
patch though.