[webkit-reviews] review denied: [Bug 124937] Move PrettyPatch related code to prettypatch.py : [Attachment 217992] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Dániel Bátyai
<Batyai.Daniel at stud.u-szeged.hu>'s request for review:
Bug 124937: Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Attachment 217992: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=217992&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217992&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:200
> +	   if self._port._pretty_patch.pretty_patch_available():
> +	       pretty_patch =
self._port._pretty_patch.pretty_patch_text(diff_filename)

We shouldn't be accessing port object's "private" variables like this.