[webkit-reviews] review granted: [Bug 124904] Add a bunch of early exits and local optimizations to the x86 assembler. : [Attachment 217982] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Nadav Rotem <nrotem at apple.com>'s
request for review:
Bug 124904: Add a bunch of early exits and local optimizations to the x86
assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Attachment 217982: Patch
https://bugs.webkit.org/attachment.cgi?id=217982&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217982&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:1246
> +	   m_assembler.addl_rr(src, dest);

Indentation looks weird - are you using tabs?  WebKit hackers use a mix of
4-space-tab editors and 8-space-tab editors so as a compromise we require tabs
to be disabled.