[webkit-reviews] review granted: [Bug 124955] Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it : [Attachment 217975] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 124955: Give the PageClient a chance to handle geolocation permission
requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955

Attachment 217975: Patch
https://bugs.webkit.org/attachment.cgi?id=217975&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217975&action=review


> Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h:60
> +    virtual bool decidePolicyForGeolocationPermissionRequest(WebFrameProxy*,
WebSecurityOrigin*, GeolocationPermissionRequestProxy*);

I think the parameters can be references and the function can be annotated as
an override.