[webkit-reviews] review granted: [Bug 124952] Make WKProcessGroup work with WKObject wrapping : [Attachment 217972] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 27 17:45:28 PST 2013


mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 124952: Make WKProcessGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124952

Attachment 217972: Patch
https://bugs.webkit.org/attachment.cgi?id=217972&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217972&action=review


> Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm:29
> +#import "WKProcessGroupInternal.h"
>  #import "WKProcessGroupPrivate.h"
>  

Please remove the Private include when adding Internal.

> Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h:26
> +#import "WKProcessGroup.h"

…and import the private header here.


More information about the webkit-reviews mailing list