[webkit-reviews] review granted: [Bug 124948] Make WKBrowsingContextGroup work with WKObject wrapping : [Attachment 217966] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 124948: Make WKBrowsingContextGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124948

Attachment 217966: Patch
https://bugs.webkit.org/attachment.cgi?id=217966&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217966&action=review


> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:30
>  #if WK_API_ENABLED

Can we remove some of the following imports, now that we don’t use C SPI here?

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm:56
> +#pragma mark WKObject protocol implementation
> +
> +- (API::Object&)_apiObject
> +{
> +    return *reinterpret_cast<API::Object*>(&_pageGroup);
> +}
> +

I’d stick this at the bottom (then it’s also clear that the following methods
aren’t part of WKObject conformance. Or use “#pragma mark -” to separate the
rest.