[webkit-reviews] review granted: [Bug 124659] [GTK] Support custom types for drag and drop data : [Attachment 217881] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 124659: [GTK] Support custom types for drag and drop data
https://bugs.webkit.org/show_bug.cgi?id=124659

Attachment 217881: Patch
https://bugs.webkit.org/attachment.cgi?id=217881&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217881&action=review


> Source/WebCore/platform/gtk/PasteboardGtk.cpp:255
> +	   HashMap<String, String>::const_iterator end = types.end();
> +	   for (HashMap<String, String>::const_iterator it = types.begin(); it
!= end; ++it)
> +	       m_dataObject->setUnknownTypeData(it->key, it->value);

We are using auto in situations like this now, I think.

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:379
> +    HashMap<String, String>::const_iterator end = unknownTypes.end();
> +    for (HashMap<String, String>::const_iterator it = unknownTypes.begin();
it != end; ++it)
> +	   types.append(it->key);

Ditto.

> Source/WebCore/platform/gtk/PasteboardHelper.cpp:197
> +	   HashMap<String, String>::const_iterator end = types.end();
> +	   for (HashMap<String, String>::const_iterator it = types.begin(); it
!= end; ++it) {
> +	       GOwnPtr<gchar> dictItem(g_strdup_printf("{'%s', '%s'}",
it->key.utf8().data(), it->value.utf8().data()));
> +	       g_variant_builder_add_parsed(&builder, dictItem.get());

Ditto.

> Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp:181
> +	   HashMap<String, String>::const_iterator end = unknownTypes.end();
> +	   for (HashMap<String, String>::const_iterator it =
unknownTypes.begin(); it != end; ++it)

auto works here too, I think.

> LayoutTests/platform/gtk/TestExpectations:228
>  # Custom MIME type support in DataTransfer is not yet implemented.
>  webkit.org/b/99068 editing/pasteboard/clipboard-customData.html [ Failure ]

Probably should update the comment now and if the test isn't expected to pass I
think it needs to move to a different section of the file.