[webkit-reviews] review granted: [Bug 124682] [ASAN] WebKitTestRunner can only load its injected bundle at the "mainBundle" path : [Attachment 217584] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 124682: [ASAN] WebKitTestRunner can only load its injected bundle at the
"mainBundle" path
https://bugs.webkit.org/show_bug.cgi?id=124682

Attachment 217584: Patch
https://bugs.webkit.org/attachment.cgi?id=217584&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217584&action=review


r=me with minor space adjustments to meet code style guidelines.

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:61
> +    if (![[NSFileManager defaultManager] fileExistsAtPath:nsBundlePath])

Missing a space between "fileExistsAtPath:" and its argument.

> Tools/WebKitTestRunner/mac/TestControllerMac.mm:62
> +	   nsBundlePath = [[[NSBundle mainBundle] bundlePath]
stringByAppendingPathComponent:@"Contents/Resources/WebKitTestRunnerInjectedBun
dle.bundle"];

Missing space between "stringByAppendingPathComponent:" and its argument.