[webkit-reviews] review denied: [Bug 124902] Adding MediaConstraintsMock class : [Attachment 217907] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 124902: Adding MediaConstraintsMock class
https://bugs.webkit.org/show_bug.cgi?id=124902

Attachment 217907: Patch
https://bugs.webkit.org/attachment.cgi?id=217907&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217907&action=review


> Source/WebCore/platform/mock/MediaConstraintsMock.cpp:52
> +bool isSupported(const String& constraint)
> +{
> +    return constraint == "valid_and_supported_1" || constraint ==
"valid_and_supported_2";
> +}
> +
> +bool isValid(const String& constraint)
> +{
> +    return isSupported(constraint) || constraint ==
"valid_but_unsupported_1" || constraint == "valid_but_unsupported_2";
> +}
> +
> +bool MediaConstraintsMock::verifyConstraints(PassRefPtr<MediaConstraints>
prpConstraints)

This duplicates functionality in MockMediaStreamCenter. I would rather you use
MockMediaStreamCenter::validateRequestConstraints and its supporting functions,
and have MockMediaStreamCenter use this.