[webkit-reviews] review requested: [Bug 124824] Create a new SymbolTable every time code is loaded so that the watchpoints don't get reused : [Attachment 217888] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 124824: Create a new SymbolTable every time code is loaded so that the
watchpoints don't get reused
https://bugs.webkit.org/show_bug.cgi?id=124824

Attachment 217888: the patch
https://bugs.webkit.org/attachment.cgi?id=217888&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Only clone if there are captured variables.  This reduces the performance
regression somewhat.  It's now:

				  TipOfTree		    CopySymTab	       
			  

3d-cube 			7.6940+-0.1180	   ?	  7.7232+-0.0728       
?
3d-morph			8.7795+-0.0635	   ?	  8.8311+-0.1250       
?
3d-raytrace			8.7119+-0.1335	   ?	  8.8288+-0.2167       
? might be 1.0134x slower
access-binary-trees		2.0083+-0.0133	   ?	  2.0196+-0.0276       
?
access-fannkuch 		8.0129+-0.0911		  7.9998+-0.1229       

access-nbody			4.2382+-0.0206	   ?	  4.2444+-0.0336       
?
access-nsieve			5.0547+-0.0857		  4.9899+-0.0222       
  might be 1.0130x faster
bitops-3bit-bits-in-byte	1.8088+-0.0129	   ?	  1.8133+-0.0222       
?
bitops-bits-in-byte		7.2445+-0.0806	   ?	  7.3056+-0.0453       
?
bitops-bitwise-and		2.9078+-0.0500	   ?	  2.9387+-0.0273       
? might be 1.0106x slower
bitops-nsieve-bits		4.6024+-0.0274		  4.5913+-0.0420       

controlflow-recursive		3.1233+-0.0085		  3.1199+-0.0145       

crypto-aes			5.4176+-0.0225	   ?	  5.4183+-0.0173       
?
crypto-md5			3.1177+-0.0592		  3.0905+-0.0303       

crypto-sha1			2.9851+-0.0929		  2.9395+-0.0064       
  might be 1.0155x faster
date-format-tofte	       11.2551+-0.1257		 11.1915+-0.1051       

date-format-xparb		8.6007+-0.1150	   ?	  8.6161+-0.1689       
?
math-cordic			4.2095+-0.0121	   ?	  4.2652+-0.0948       
? might be 1.0132x slower
math-partial-sums	       10.2620+-0.1227	   ?	 10.2844+-0.1139       
?
math-spectral-norm		2.7493+-0.0659		  2.7211+-0.0073       
  might be 1.0104x faster
regexp-dna		       12.8357+-0.0775	   ?	 12.9096+-0.0793       
?
string-base64			5.4462+-0.0282	   ?	  5.4549+-0.0201       
?
string-fasta		       10.1331+-0.1146	   ?	 10.1621+-0.1004       
?
string-tagcloud 	       14.8699+-0.1560		 14.8458+-0.1224       

string-unpack-code	       30.0857+-0.1233	   !	 31.7528+-0.1392       
! definitely 1.0554x slower
string-validate-input		6.9770+-0.1305		  6.9281+-0.0891       


<arithmetic> *			7.4281+-0.0138	   !	  7.4994+-0.0130       
! definitely 1.0096x slower
<geometric>			5.9576+-0.0111	   ?	  5.9730+-0.0099       
? might be 1.0026x slower
<harmonic>			4.8713+-0.0131	   ?	  4.8730+-0.0123       
? might be 1.0004x slower