[webkit-reviews] review granted: [Bug 103312] [CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax : [Attachment 216577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 26 10:02:28 PST 2013


Andreas Kling <akling at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 103312: [CSS Grid Layout] Support grid-definition-{rows|columns} repeat()
syntax
https://bugs.webkit.org/show_bug.cgi?id=103312

Attachment 216577: Patch
https://bugs.webkit.org/attachment.cgi?id=216577&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216577&action=review


r=me

> Source/WebCore/css/CSSParser.cpp:5048
> +	       values->append(primitiveValue);

values->append(primitiveValue.release());

> Source/WebCore/css/CSSParser.cpp:5086
> +	   repeatedValues->append(trackSize);

repeatedValues->append(trackSize.release());


More information about the webkit-reviews mailing list