[webkit-reviews] review granted: [Bug 124555] [EFL] Use Config mode of find_package for EFL 1.8 : [Attachment 217495] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 124555: [EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Attachment 217495: Patch
https://bugs.webkit.org/attachment.cgi?id=217495&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217495&action=review


Looks fine.

> Source/cmake/OptionsEfl.cmake:136
> +    if (NOT (CMAKE_VERSION VERSION_LESS 2.8.8))

Isn't there CMAKE_VERSION_VERSION_MORE or similar thing ? It looks this is
double *not not* condition. If there is no similar thing, this is fine.