[webkit-reviews] review granted: [Bug 124454] [Win] WebKit version in user agent string is incorrect. : [Attachment 217834] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted peavo at outlook.com's request for
review:
Bug 124454: [Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454

Attachment 217834: Patch
https://bugs.webkit.org/attachment.cgi?id=217834&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217834&action=review


Looks great! You might want to omit the macro as I describe below. But it's
fine as-is. R=me.

> Source/WebKit/win/WebView.cpp:2492
> +#if !USE(CAIRO)

I'm not sure that we need this macro at all. If WinCairo doesn't define
BUILD_NUMBER it should just do the right thing. That way, you can define it
yourself for future builds.