[webkit-reviews] review denied: [Bug 124810] Make isSelfCollapsingBlock() a virtual RenderObject function : [Attachment 217750] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 124810: Make isSelfCollapsingBlock() a virtual RenderObject function
https://bugs.webkit.org/show_bug.cgi?id=124810

Attachment 217750: Patch
https://bugs.webkit.org/attachment.cgi?id=217750&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=217750&action=review


> Source/WebCore/rendering/RenderBlockFlow.cpp:1184
> -    if (lastBlock && lastBlock->isRenderBlockFlow() &&
toRenderBlockFlow(lastBlock)->isSelfCollapsingBlock())
> +    if (lastBlock && lastBlock->isSelfCollapsingBlock())

We want to tighten typing, not loosen it. There is no reason these functions
should take RenderObject. At minimum it should be RenderElement and considering
the variable is called "lastBlock" it likely should be at least RenderBlock.