[webkit-reviews] review granted: [Bug 124819] DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses can connect to : [Attachment 217765] Patch v2 - Fix includes leftover from a stash merge.

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 124819: DatabaseProcess: Add "UniqueIDBDatabase" that multiple WebProcesses
can connect to
https://bugs.webkit.org/show_bug.cgi?id=124819

Attachment 217765: Patch v2 - Fix includes leftover from a stash merge.
https://bugs.webkit.org/attachment.cgi?id=217765&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217765&action=review


> Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:81
> +    RefPtr<UniqueIDBDatabase> database = m_idbDatabases.get(identifier);
> +    if (database)
> +	   return database;
> +
> +    database = UniqueIDBDatabase::create(identifier);
> +    m_idbDatabases.set(identifier, database);
> +
> +    return database.release();

Is there a way to do this without hashing twice in the not-found case? I think
there is (using HashMap::find).

> Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:70
> +    UniqueIDBDatabaseIdentifier m_databaseIdentifier;

Why do we need this as a member variable here and can’t rely on getting the
identifier from the m_uniqueIDBDatabase member?

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h:58
> +    mutable String m_identifierString;

This doesn’t appear to be used.