[webkit-reviews] review granted: [Bug 124804] Add DatabaseProcessCreationParameters, starting with the database path. : [Attachment 217733] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 17:50:32 PST 2013


Dean Jackson <dino at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 124804: Add DatabaseProcessCreationParameters, starting with the database
path.
https://bugs.webkit.org/show_bug.cgi?id=124804

Attachment 217733: Patch v2
https://bugs.webkit.org/attachment.cgi?id=217733&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217733&action=review


> Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:32
> +#include "SecurityOriginData.h"

Not sure why you need this, but I guess you do.

> Source/WebKit2/DatabaseProcess/DatabaseProcess.h:38
> +struct SecurityOriginData;

... and here.

> Source/WebKit2/UIProcess/WebContext.cpp:422
> +    // Indexed databases exist in a subdirectory of the "database directory
path"

Nit: .


More information about the webkit-reviews mailing list