[webkit-reviews] review denied: [Bug 124549] run-jsc-stress-tests should be able to package its tests and move them places : [Attachment 217713] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 124549: run-jsc-stress-tests should be able to package its tests and move
them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Attachment 217713: Patch
https://bugs.webkit.org/attachment.cgi?id=217713&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217713&action=review


> Tools/Scripts/run-jsc-stress-tests:355
> +	       if key == "DYLD_FRAMEWORK_PATH"
> +		   script += "export #{key}=$(cd ../#{$frameworkPath.dirname};
pwd)\n"

Change this to not be an IMPORTANT_ENV and handle it outside the loop.

> Tools/Scripts/run-jsc-stress-tests:611
> +    $extraFilesBaseDir = $extraFilesBaseDir.dirname unless
$extraFilesBaseDir.basename == $benchmarkDirectory.basename

Don't change this here.