[webkit-reviews] review granted: [Bug 124785] Add TextTrackList::getTrackById(). : [Attachment 217708] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 22 12:52:23 PST 2013
Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 124785: Add TextTrackList::getTrackById().
https://bugs.webkit.org/show_bug.cgi?id=124785
Attachment 217708: Patch
https://bugs.webkit.org/attachment.cgi?id=217708&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217708&action=review
> Source/WebCore/html/track/TextTrackList.cpp:143
> + return 0;
Nit: nullptr
> Source/WebCore/html/track/TextTrackList.h:51
> + TextTrack* getTrackById(const AtomicString& id);
Nit: "id" is unnecessary.
More information about the webkit-reviews
mailing list