[webkit-reviews] review denied: [Bug 124761] Combine SymbolTable and SharedSymbolTable : [Attachment 217652] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 124761: Combine SymbolTable and SharedSymbolTable
https://bugs.webkit.org/show_bug.cgi?id=124761

Attachment 217652: the patch
https://bugs.webkit.org/attachment.cgi?id=217652&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Approach looks good to me, but build is broken:

Undefined symbols for architecture x86_64:
  "__ZNK3JSC7JSValuecvPMS0_PvEv", referenced from:
      __ZN3JSC11SymbolTableC1ERNS_2VME in SymbolTable.o
      __ZN3JSC11SymbolTableC2ERNS_2VME in SymbolTable.o
  "__ZNK3JSC7JSValue6asCellEv", referenced from:
      __ZN3JSC11SymbolTableC1ERNS_2VME in SymbolTable.o
      __ZN3JSC11SymbolTableC2ERNS_2VME in SymbolTable.o

Maybe you need to #include JSValueInlines.h?