[webkit-reviews] review granted: [Bug 124745] Add a setting to opt into a mode where the background extends and fixed elements don't move on rubber-band : [Attachment 217616] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 09:48:46 PST 2013


Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 124745: Add a setting to opt into a mode where the background extends and
fixed elements don't move on rubber-band
https://bugs.webkit.org/show_bug.cgi?id=124745

Attachment 217616: Patch
https://bugs.webkit.org/attachment.cgi?id=217616&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217616&action=review


EFL error is "c++: internal compiler error: Killed (program cc1plus)" so we
don't care.

> Source/WebCore/page/Settings.in:216
> +backgroundShouldExtendBeyondPage initial=false,
setNeedsStyleRecalcInAllFrames=1

Do you need the style recalc? Are we intending for this to be switchable, live?
I don't think it will be as it stands, so maybe you don't need this either.


More information about the webkit-reviews mailing list