[webkit-reviews] review canceled: [Bug 124534] [GStreamer] Remove 0.10 codepath : [Attachment 217635] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has canceled Xabier Rodríguez
Calvar <calvaris at igalia.com>'s request for review:
Bug 124534: [GStreamer] Remove 0.10 codepath
https://bugs.webkit.org/show_bug.cgi?id=124534

Attachment 217635: Patch
https://bugs.webkit.org/attachment.cgi?id=217635&action=review

------- Additional Comments from Xabier Rodríguez Calvar <calvaris at igalia.com>
(In reply to comment #10)
Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h:74
> > +void mapGstBuffer(GstBuffer*);
> > +void unmapGstBuffer(GstBuffer*);
> > +
> >  namespace WebCore {
> >  bool initializeGStreamer();
> >  }
> 
> I wonder why the moved functions aren't in the WebCore namespace like the
initializeGStreamer function.

Cause they weren't before. Do you prefer them inside?

Btw, I spotted a little problem with the IntSize class, which is now included
in the .h instead of forwarded. I'll upload a new patch.