[webkit-reviews] review granted: [Bug 124572] Map the dir attribute to the CSS direction property : [Attachment 217541] Follow up V3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Frédéric Wang <fred.wang at free.fr>'s
request for review:
Bug 124572: Map the dir attribute to the CSS direction property
https://bugs.webkit.org/show_bug.cgi?id=124572

Attachment 217541: Follow up V3
https://bugs.webkit.org/attachment.cgi?id=217541&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217541&action=review


> Source/WebCore/mathml/MathMLElement.cpp:128
> +bool MathMLElement::isMathMLToken() const
> +{
> +    return hasTagName(miTag) || hasTagName(mnTag) || hasTagName(moTag) ||
hasTagName(msTag) || hasTagName(mtextTag);
> +}

Are you sure this is actually getting inlined? In older compilers we had to put
the function higher in the file than the call sites, and also mark it inline
here, not just in the declaration.