[webkit-reviews] review granted: [Bug 124599] [Mac] 10X slower than Chrome when drawing a video into a canvas : [Attachment 217339] Follow up patch to address Darin's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 124599: [Mac] 10X slower than Chrome when drawing a video into a canvas
https://bugs.webkit.org/show_bug.cgi?id=124599

Attachment 217339: Follow up patch to address Darin's comments
https://bugs.webkit.org/attachment.cgi?id=217339&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217339&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:203
> +- (void)setCallback:(MediaPlayerPrivateAVFoundationObjC*)callback;

Funny that you added this without a "*". I also think we probably could just
have a clearCallback method instead of one that takes a pointer.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:302
> +    [m_videoOutputDelegate setCallback:0];

nullptr

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:303
> +    [m_videoOutput setDelegate:nil queue:0];

nullptr