[webkit-reviews] review granted: [Bug 124735] BytecodeGenerator should align the stack according to native conventions : [Attachment 217613] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 124735: BytecodeGenerator should align the stack according to native
conventions
https://bugs.webkit.org/show_bug.cgi?id=124735

Attachment 217613: the patch
https://bugs.webkit.org/attachment.cgi?id=217613&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217613&action=review


r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:72
> +	   unsigned registerOffset() { return -(m_argv[0]->index() -
JSStack::CallFrameHeaderSize); }

You're doing double negate on JSStack::CallFrameHeaderSize here.  Instead,
please change this to:
    return -m_argv[0]->index() + JSStack::CallFrameHeaderSize;

Also, though the name registerOffset() is probably outdated.  From looking at
the code, I think it would be more appropriately renamed numberOfRegisters() or
registerCount().  If you agree, would you mind changing that as well?

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:440
> +    

Please remove the blank spaces on this line.