[webkit-reviews] review granted: [Bug 124734] [WebIDL] Introduce the Unforgeable IDL attribute : [Attachment 217596] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 124734: [WebIDL] Introduce the Unforgeable IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=124734

Attachment 217596: Patch
https://bugs.webkit.org/attachment.cgi?id=217596&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217596&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4199
> +    return $function->signature->extendedAttributes->{"Unforgeable"} ||
$interface->extendedAttributes->{"Unforgeable"};

This adds per-function Unforgeable as well as per-interface Unforgeable, but I
don’t see any test coverage for the per-function one. We have bindings tests,
and it should be easy to add coverage to them.