[webkit-reviews] review denied: [Bug 124579] Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code. : [Attachment 217544] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied László Langó
<lango at inf.u-szeged.hu>'s request for review:
Bug 124579: Use unsigned consistently, and check for invalid casts when calling
into SharedBuffer from other code.
https://bugs.webkit.org/show_bug.cgi?id=124579

Attachment 217544: Patch
https://bugs.webkit.org/attachment.cgi?id=217544&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217544&action=review


There are even more threads that need to be pulled :(

See for example this line in WebCoreResourceHandleAsDelegate.mm:

    m_handle->client()->willStopBufferingData(m_handle, (const char*)[data
bytes], static_cast<int>([data length]));

willStopBufferingData is the first and only name I grepped for, so
probabilistically speaking, there are likely more implicit casts remaining.
Please grep WebCore for every function name you changed.

> Source/WebCore/loader/ResourceLoader.cpp:1
> -/*
> + /*

Accidental change here.