[webkit-reviews] review granted: [Bug 123406] check-webkit-style should support C++11 rvalue references : [Attachment 217418] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted  review:
Bug 123406: check-webkit-style should support C++11 rvalue references
https://bugs.webkit.org/show_bug.cgi?id=123406

Attachment 217418: Patch
https://bugs.webkit.org/attachment.cgi?id=217418&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217418&action=review


R=me

>>> Tools/Scripts/webkitpy/style/checkers/cpp.py:2626
>>> +	 if cleansed_line.strip().endswith('||') or
cleansed_line.strip().endswith(' &&'):
>> 
>> Won't strip() remove all the whitespace?  Will we ever match ' &&'?
> 
> stip() method only remove the leading end trailing whitespaces. It won't
remove the whitespace before '&&'. Just to be sure a i checked it before i
uploaded the patch. End already exists a test that check the multiline
conditions (last assert in 'test_brace_at_begin_of_line').

Great! Thanks for confirming.