[webkit-reviews] review granted: [Bug 124694] Allow settings to be shown/hidden on build.webkit.org/dashboard : [Attachment 217506] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 17:54:25 PST 2013


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 124694: Allow settings to be shown/hidden on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124694

Attachment 217506: Patch
https://bugs.webkit.org/attachment.cgi?id=217506&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217506&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/M
ain.js:181
> +    settingsButton.addEventListener("click", function () {
settings.toggleSettingsDisplay(); });

space before ()? I don't remember


More information about the webkit-reviews mailing list