[webkit-reviews] review granted: [Bug 124676] webkitdirs::checkForArgumentAndRemoveFromArrayRef() removes wrong element : [Attachment 217480] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 124676: webkitdirs::checkForArgumentAndRemoveFromArrayRef() removes wrong
element
https://bugs.webkit.org/show_bug.cgi?id=124676

Attachment 217480: Patch
https://bugs.webkit.org/attachment.cgi?id=217480&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217480&action=review


This patch look a reasonable to me. Ideally, we could reduce some duplication
of code in the unit test. For now, it's OK.

> Tools/ChangeLog:3
> +	   Fix a bug in webkitdirs::checkForArgumentAndRemoveFromArrayRef

This title is ambiguous. I updated the Bugzilla bug title to be:
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element

Feel free to use this bug title or come up with a more descriptive one.