[webkit-reviews] review denied: [Bug 124675] [Win] JavaScript JIT crash (with DFG enabled). : [Attachment 217474] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 20 15:09:44 PST 2013


Geoffrey Garen <ggaren at apple.com> has denied peavo at outlook.com's request for
review:
Bug 124675: [Win] JavaScript JIT crash (with DFG enabled).
https://bugs.webkit.org/show_bug.cgi?id=124675

Attachment 217474: Patch
https://bugs.webkit.org/attachment.cgi?id=217474&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
What this means is that there's some Windows-specific DFG code that uses
"nonArgGPR0" when it should have used "regT0". Your patch hides the bug by
making nonArgGPR0 equal to regT0. That's not a good long-term solution because
the two registers can't be equal on all platforms.


More information about the webkit-reviews mailing list