[webkit-reviews] review granted: [Bug 120188] AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after) : [Attachment 216611] patch (with removed code duplication)

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 120188: AX: Implement CSS -webkit-alt property (text alternative for
generated content pseudo-elements ::before and ::after)
https://bugs.webkit.org/show_bug.cgi?id=120188

Attachment 216611: patch (with removed code duplication)
https://bugs.webkit.org/attachment.cgi?id=216611&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216611&action=review


Overall I wonder if altText should be alternateText, but I guess the attribute
name is well know in HTML.

> Source/WebCore/ChangeLog:11
> +	   it sets that string on the TextFragment or RenderImage, which can be
queiered by accessibility code.

typo: queried

> Source/WebCore/css/CSSParser.cpp:3804
> +	   // attr(X)

I don't think we need this line.

> Source/WebCore/css/StyleResolver.cpp:2272
> +		   // register the fact that the attribute value affects the
style

Nit: Uppercase R and end with .

> LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content.html:17
> +/* webkit-alt on image content that string. */

Typo: is a string

> LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content.html:86
> +	   debug("Test2 - webkit-alt on image content that string");

Typo here too.