[webkit-reviews] review granted: [Bug 76677] AXPress event coordinates are always sent as (0, 0) : [Attachment 214379] Updated patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 76677: AXPress event coordinates are always sent as (0, 0)
https://bugs.webkit.org/show_bug.cgi?id=76677

Attachment 214379: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=214379&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214379&action=review


> Source/WebCore/dom/Element.cpp:1004
> +	   return
document().view()->contentsToRootView(renderer->absoluteBoundingBoxRect());

Does this do the right thing if the root view is scrolled?

> Source/WebCore/dom/Element.cpp:1011
> +    if (RenderObject* renderer = this->renderer())
> +	   return
document().view()->contentsToScreen(renderer->absoluteBoundingBoxRect());

Is this actually fixing a bug? Should you add a test for it?

> Source/WebCore/dom/Element.h:226
> +    

Whitespace