[webkit-reviews] review granted: [Bug 124673] Use std::function callbacks in CryptoAlgorithm instead of JS promises : [Attachment 217463] proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 124673: Use std::function callbacks in CryptoAlgorithm instead of JS
promises
https://bugs.webkit.org/show_bug.cgi?id=124673

Attachment 217463: proposed patch
https://bugs.webkit.org/attachment.cgi?id=217463&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217463&action=review


> Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:68
> +    callback(result.get(), 0);

nullptr?

> Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:63
> +	   callback(0, &pair);

nullptr?

> Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:222
> +    KeyPairCallback* localCallback = new KeyPairCallback(callback);

Can std::move callback here to avoid a copy.

> Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp:223
> +    VoidCallback* localFailureCallback = new VoidCallback(failureCallback);

Ditto for failureCallback.