[webkit-reviews] review denied: [Bug 124549] run-jsc-stress-tests should be able to package its tests and move them places : [Attachment 217439] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 124549: run-jsc-stress-tests should be able to package its tests and move
them places
https://bugs.webkit.org/show_bug.cgi?id=124549

Attachment 217439: Patch
https://bugs.webkit.org/attachment.cgi?id=217439&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217439&action=review


How does this handle extra files for Kraken, Octane, etc?

> Tools/Scripts/run-jsc-stress-tests:289
> +    attr_accessor :baseForExtraFiles
> +    def add(localTestPath, testName)

I would put a blank line between attr_accessor and def add.

> Tools/Scripts/run-jsc-stress-tests:317
> +	   self.addLayoutTestFiles

Remove self.

> Tools/Scripts/run-jsc-stress-tests:337
> +	   self.add(LAYOUTTESTS_RELATIVE_PATH + "resources",
"standalone-pre.js")

Remove self.

> Tools/Scripts/run-jsc-stress-tests:338
> +	   self.add(LAYOUTTESTS_RELATIVE_PATH + "resources",
"standalone-post.js")

Remove self.

> Tools/Scripts/run-jsc-stress-tests:344
> +	       self.add(@baseForExtraFiles, file)

Remove self.