[webkit-reviews] review granted: [Bug 124406] [GTK] Mark all deprecated symbols in GObject DOM bindings : [Attachment 217391] Updated patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 124406: [GTK] Mark all deprecated symbols in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=124406

Attachment 217391: Updated patch
https://bugs.webkit.org/attachment.cgi?id=217391&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217391&action=review


LGTM with one minor nit:

> Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp:22
> +#if !defined(WEBKIT_DISABLE_DEPRECATED)

I don't think we want this in the implementation file, just on the header,
since it's something that should be used only by stuff that use WebKit at build
time only.