[webkit-reviews] review granted: [Bug 124635] Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2 : [Attachment 217384] Patch v1 with code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 23:18:50 PST 2013


Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 124635: Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
https://bugs.webkit.org/show_bug.cgi?id=124635

Attachment 217384: Patch v1 with code.
https://bugs.webkit.org/attachment.cgi?id=217384&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217384&action=review


> Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h:-63
> -    virtual void open(const String& name, uint64_t version, int64_t
transactionId, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBDatabaseCallbacks>,
const SecurityOrigin& openingOrigin, const SecurityOrigin& mainFrameOrigin) =
0;

what's with the deconstification? (will probably be explained later in the
patch). Weren't we bitten by mutable securityorigins in the past?


More information about the webkit-reviews mailing list