[webkit-reviews] review denied: [Bug 124046] [WebGL] Removing unnecessary pointer checks : [Attachment 216399] glbuffer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 17:41:02 PST 2013


Brent Fulgham <bfulgham at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 124046: [WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046

Attachment 216399: glbuffer
https://bugs.webkit.org/attachment.cgi?id=216399&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216399&action=review


True!  Thanks for catching this. Can you revise the ChangeLog slightly per my
comments?

> Source/WebCore/ChangeLog:8
> +	   Pointer to array member can be check only once. It is not need

The log message is a little incorrect.	I think it should read:

"The array argument does not need to checked for NULL more than once."


More information about the webkit-reviews mailing list