[webkit-reviews] review granted: [Bug 124599] [Mac] 10X slower than Chrome when drawing a video into a canvas : [Attachment 217322] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 124599: [Mac] 10X slower than Chrome when drawing a video into a canvas
https://bugs.webkit.org/show_bug.cgi?id=124599

Attachment 217322: Patch
https://bugs.webkit.org/attachment.cgi?id=217322&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217322&action=review


> Source/WebCore/html/HTMLVideoElement.h:74
>  
> +
> +
>      bool shouldDisplayPosterImage() const { return displayMode() == Poster
|| displayMode() == PosterWaitingForVideo; }

Why so spacey?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1351
> +    // pixelBuffer will be of type kCVPixelFormatType_32BGRA

Nit: Ending .

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1360
> +    CFRetain(pixelBuffer); // Balanced by CVPixelBufferReleaseInfoCallback
in providerCallbacks

Ditto.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1412
> +    // Wait for 1 second

Ditto.