[webkit-reviews] review granted: [Bug 124595] Get rid of bare new in SVGAnimatedColorAnimator::constructFromString() : [Attachment 217315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 12:47:57 PST 2013


Darin Adler <darin at apple.com> has granted Sergio Correia (qrwteyrutiyoup)
<sergio.correia at openbossa.org>'s request for review:
Bug 124595: Get rid of bare new in
SVGAnimatedColorAnimator::constructFromString()
https://bugs.webkit.org/show_bug.cgi?id=124595

Attachment 217315: Patch
https://bugs.webkit.org/attachment.cgi?id=217315&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217315&action=review


> Source/WebCore/svg/SVGAnimatedTypeAnimator.h:79
> +	   executeAction<AnimValType>(StartAnimationAction, animatedTypes, 0,
copy.get());

Given this call site, looks like executeAction should be taking a reference
rather than a pointer. Some day we should make that change.


More information about the webkit-reviews mailing list