[webkit-reviews] review granted: [Bug 124597] Consolidate IDBBackingStore*Interface and IDBBackingStore*LevelDB : [Attachment 217319] Patch v1

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 124597: Consolidate IDBBackingStore*Interface and IDBBackingStore*LevelDB
https://bugs.webkit.org/show_bug.cgi?id=124597

Attachment 217319: Patch v1
https://bugs.webkit.org/attachment.cgi?id=217319&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217319&action=review


> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:60
> +    virtual PassRefPtr<IDBKey> key() const { return m_currentKey; }

Why PassRefPtr?!

> Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:68
> +    virtual PassRefPtr<IDBKey> primaryKey() const { return m_currentKey; }
> +    virtual PassRefPtr<SharedBuffer> value() const = 0;

Ditto.