[webkit-reviews] review denied: [Bug 124579] Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code. : [Attachment 217297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 19 09:34:04 PST 2013


Brent Fulgham <bfulgham at webkit.org> has denied László Langó
<lango at inf.u-szeged.hu>'s request for review:
Bug 124579: Use unsigned consistently, and check for invalid casts when calling
into SharedBuffer from other code.
https://bugs.webkit.org/show_bug.cgi?id=124579

Attachment 217297: Patch
https://bugs.webkit.org/attachment.cgi?id=217297&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
You changed the type signature of some symbols that are exported by the
WebCore.order file.  Update the entry for __ZN7WebCore12SharedBufferC1EPKci to
match the new __ZN7WebCore12SharedBufferC1EPKhi signature.


More information about the webkit-reviews mailing list