[webkit-reviews] review granted: [Bug 124560] [EFL] Initialize efreet before getting directories : [Attachment 217270] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 18 23:13:29 PST 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 124560: [EFL] Initialize efreet before getting directories
https://bugs.webkit.org/show_bug.cgi?id=124560

Attachment 217270: Patch
https://bugs.webkit.org/attachment.cgi?id=217270&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217270&action=review


Looks good except for a log.

> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:83
> +	   CRITICAL("could not init ecore_imf.");

ecore imf ? Isn't it correct "init efreet ?


More information about the webkit-reviews mailing list