[webkit-reviews] review granted: [Bug 124544] Web Inspector: Update WebInspectorUI to use the new "nodeIds" parameter for DOM.performSearch : [Attachment 217245] Patch V1

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 124544: Web Inspector: Update WebInspectorUI to use the new "nodeIds"
parameter for DOM.performSearch
https://bugs.webkit.org/show_bug.cgi?id=124544

Attachment 217245: Patch V1
https://bugs.webkit.org/attachment.cgi?id=217245&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217245&action=review


> Source/WebInspectorUI/UserInterface/DOMTreeContentView.js:215
> -	   DOMAgent.performSearch(query, searchResultsReady.bind(this));
> +	   function contextNodesReady(nodeIds)
> +	   {
> +	       DOMAgent.performSearch(query, nodeIds,
searchResultsReady.bind(this));
> +	   }

NOTE TO SELF: Adding an extra optional parameter like this does not break iOS 6
and 7 compatibility. So this is good.

This might even be a good comment to throw into the ChangeLog.

> Source/WebInspectorUI/UserInterface/DOMTreeContentView.js:224
> +	   callback();

Nit: I would prefer to see callback(undefined) to more explicitly show we're
passing undefined to performSearch.